Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Program Card Images] Polish the admin page UI #6272

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

caitlinshk
Copy link
Collaborator

@caitlinshk caitlinshk commented Dec 27, 2023

Description

This PR makes minor edits to the admin program image upload page to align it closer to the Figma mocks. Specifically:

  • Update the title
  • Add some directions about uploading an image
  • Move the image description form to the right side
  • Add placeholder text to the image description form
  • Update wordings on the image description form

Release notes

Checklist

General

Read the full guidelines for PRs here

  • Added the correct label: < feature | enhancement | bug | dependencies | infrastructure | ignore-for-release | database >
  • Assigned to a specific person, civiform/developers, or a more specific round-robin list.
  • Performed manual testing (Chrome and Firefox if it includes front-end changes)

User visible changes

  • Manually tested at 200% size
  • Manually evaluated tab order

New Features

Instructions for manual testing

  1. Enable the PROGRAM_CARD_IMAGES flag.
  2. As an admin, edit a program then click the "Edit program image" button.
  3. Verify that the page looks like a close approximation to the Figma mocks. I don't think we're going to get it perfect, but this seems close! Once this is submitted, Ron and Shreya can review and give any additional updates needed.

Issue(s) this completes

Epic #5676

Fixes #5999 (sub-task)

@caitlinshk caitlinshk force-pushed the caitlinshk_pci_admin_page_polish branch from 2cd1300 to 63e38d6 Compare December 27, 2023 18:06
@caitlinshk caitlinshk changed the title Admin page polish [Program Card Images] Polish the admin page UI Dec 27, 2023
@caitlinshk caitlinshk added the feature A significant new feature or functionality label Dec 27, 2023
@caitlinshk caitlinshk marked this pull request as ready for review December 27, 2023 18:16
@caitlinshk caitlinshk force-pushed the caitlinshk_pci_admin_page_polish branch 2 times, most recently from a8cc05f to c49736d Compare December 27, 2023 19:09
Base automatically changed from caitlinshk_pci_breadcrumb to main December 27, 2023 20:17
@caitlinshk caitlinshk force-pushed the caitlinshk_pci_admin_page_polish branch from f9ddbe8 to a2832c9 Compare December 27, 2023 20:20
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46ab582) 81.60% compared to head (a2832c9) 81.60%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6272   +/-   ##
=========================================
  Coverage     81.60%   81.60%           
  Complexity     3391     3391           
=========================================
  Files           415      415           
  Lines         14654    14654           
  Branches        962      962           
=========================================
  Hits          11958    11958           
  Misses         2288     2288           
  Partials        408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caitlinshk caitlinshk merged commit 82d2951 into main Dec 28, 2023
23 of 38 checks passed
@caitlinshk caitlinshk deleted the caitlinshk_pci_admin_page_polish branch December 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A significant new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Program Card Images] [Admin] Implement file upload UI
2 participants