Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH helper function to list models #314

Merged
merged 6 commits into from
Aug 2, 2019

Conversation

elsander
Copy link
Contributor

@elsander elsander commented Aug 2, 2019

This PR adds a helper function to list a user's models (training, prediction, or both).

Copy link

@stephen-hoover stephen-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I think should definitely happen is adding the __all__. Others are suggestions for the user interface.

civis/ml/_helper.py Outdated Show resolved Hide resolved
civis/ml/_helper.py Show resolved Hide resolved
civis/ml/_helper.py Outdated Show resolved Hide resolved
civis/ml/tests/test_helper.py Outdated Show resolved Hide resolved
civis/ml/_helper.py Show resolved Hide resolved
@elsander elsander assigned stephen-hoover and unassigned elsander Aug 2, 2019
Copy link

@stephen-hoover stephen-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elsander elsander merged commit 84ecf67 into civisanalytics:master Aug 2, 2019
@elsander elsander deleted the list-models branch August 2, 2019 22:03
@stephen-hoover stephen-hoover added this to the v1.11.0 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants