Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some minor issues that flake8 3.8 finds #394

Merged
merged 1 commit into from
May 13, 2020

Conversation

mheilman
Copy link
Contributor

related to #393

@mheilman mheilman changed the title fix some minor issues that flake8 3.8 flags fix some minor issues that flake8 3.8 finds May 12, 2020
Copy link

@stephen-hoover stephen-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So flake8 thinks that l is an ambiguous name, but x is not?

@mheilman
Copy link
Contributor Author

Ha, yeah, I was wondering the same thing. It means visually ambiguous (e.g., "l" vs "I"), so it kinda makes sense (though fixed width fonts usually render those differently: l vs I).

https://www.flake8rules.com/rules/E741.html

@mheilman mheilman merged commit 6f8c001 into civisanalytics:master May 13, 2020
@mheilman mheilman deleted the support_flake3.8 branch May 13, 2020 14:31
@stephen-hoover
Copy link

Ha, yeah, I was wondering the same thing. It means visually ambiguous (e.g., "l" vs "I"), so it kinda makes sense (though fixed width fonts usually render those differently: l vs I).

https://www.flake8rules.com/rules/E741.html

That makes a lot of sense, now that you point it out. I'm happy to have that check in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants