[APIC-306] Fixed a bug in parsing responses that included "update" as a key #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheilman
force-pushed
the
fix-response-parsing
branch
from
dab3d2e
to
11b5c85
Compare
mheilman
commented
Sep 11, 2020
…., in column information from `client.tables.get(...)`)
mheilman
force-pushed
the
fix-response-parsing
branch
from
11b5c85
to
4b1992c
Compare
mheilman
commented
Sep 11, 2020
| @@ -174,3 +174,15 @@ def test_convert_data_type_civis_list(): | |||
| assert isinstance(data[0], Response) | |||
| assert data[0]['foo'] == 'bar' | |||
| assert data[0].headers == {'header': 'val'} | |||
|
|
|||
|
|
|||
| def test_parse_column_names(): | |||
There was a problem hiding this comment.
this test would fail before
salilgupta1
reviewed
Sep 14, 2020
|
|
||
| self.update(self_updates) | ||
| # Update self.__dict__ at the end to avoid replacing the update method. | ||
| self.__dict__.update(self_updates) |
There was a problem hiding this comment.
so the issue is that the update key was overwriting the dictionary update method?
There was a problem hiding this comment.
yeah, and then the next update call would fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a column named "update" would cause response parsing to fail for
/tablesendpoints.The
civis.response.Responseprovides convenient access to response attributes (e.g.,response.attribas opposed toresponse['attrib']). In retrospect, perhaps it'd have been better not to have that functionality recur all the way down the response structure (or at least not into user-provided table info), but that ship has sailed, and in order to minimize breaking changes, this PR should preserve the existing functionality and avoid the bug.