Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIC-280] DOC clarify table_columns param in civis.io functions #434

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

gkcivis
Copy link
Contributor

@gkcivis gkcivis commented Nov 18, 2021

Clarify table_columns parameter per https://civisanalytics.atlassian.net/browse/APIC-280

@jacksonlee-civis jacksonlee-civis changed the title [APIC-280] clarify table_columns param in civis.io functions [APIC-280] DOC clarify table_columns param in civis.io functions Nov 19, 2021
Copy link
Member

@jacksonlee-civis jacksonlee-civis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkcivis These changes are great! The TravisCI builds failed because flake8 was upset:

civis/io/_tables.py:684:80: E501 line too long (82 > 79 characters)
civis/io/_tables.py:684:83: W291 trailing whitespace
civis/io/_tables.py:685:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:685:81: W291 trailing whitespace
civis/io/_tables.py:686:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:687:79: W291 trailing whitespace
civis/io/_tables.py:688:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:688:81: W291 trailing whitespace
civis/io/_tables.py:689:80: E501 line too long (82 > 79 characters)
civis/io/_tables.py:689:83: W291 trailing whitespace
civis/io/_tables.py:690:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:690:81: W291 trailing whitespace
civis/io/_tables.py:691:74: W291 trailing whitespace
civis/io/_tables.py:693:59: W291 trailing whitespace
civis/io/_tables.py:834:80: E501 line too long (82 > 79 characters)
civis/io/_tables.py:834:83: W291 trailing whitespace
civis/io/_tables.py:835:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:835:81: W291 trailing whitespace
civis/io/_tables.py:836:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:837:79: W291 trailing whitespace
civis/io/_tables.py:838:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:838:81: W291 trailing whitespace
civis/io/_tables.py:839:80: E501 line too long (82 > 79 characters)
civis/io/_tables.py:839:83: W291 trailing whitespace
civis/io/_tables.py:840:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:840:81: W291 trailing whitespace
civis/io/_tables.py:841:74: W291 trailing whitespace
civis/io/_tables.py:843:59: W291 trailing whitespace
civis/io/_tables.py:970:80: E501 line too long (82 > 79 characters)
civis/io/_tables.py:970:83: W291 trailing whitespace
civis/io/_tables.py:971:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:971:81: W291 trailing whitespace
civis/io/_tables.py:972:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:973:79: W291 trailing whitespace
civis/io/_tables.py:974:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:974:81: W291 trailing whitespace
civis/io/_tables.py:975:80: E501 line too long (82 > 79 characters)
civis/io/_tables.py:975:83: W291 trailing whitespace
civis/io/_tables.py:976:80: E501 line too long (80 > 79 characters)
civis/io/_tables.py:976:81: W291 trailing whitespace
civis/io/_tables.py:977:74: W291 trailing whitespace
civis/io/_tables.py:979:59: W291 trailing whitespace

(Note to our future selves: This PR partially addresses #380, but we have to leave that GitHub issue open even after this PR is merged, because we have yet to address a related doc issue from the Platform API -- see the linked ticket from the current APIC-280)

@gkcivis
Copy link
Contributor Author

gkcivis commented Nov 19, 2021

Is there a way to re-run TravisCI on the latest commit?

Copy link
Member

@jacksonlee-civis jacksonlee-civis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The TravisCI builds ran eventually 🐢 and finished with no errors. We should be good now!

@gkcivis gkcivis merged commit f49595c into master Nov 19, 2021
@gkcivis gkcivis deleted the clarify-table-columns branch November 19, 2021 15:51
@jacksonlee-civis jacksonlee-civis added this to the v1.16.0 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants