Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIVIS-1509] DOC improve documentation of input to civis.io.civis_file_to_table #445

Merged
merged 4 commits into from
Dec 8, 2021
Merged

[CIVIS-1509] DOC improve documentation of input to civis.io.civis_file_to_table #445

merged 4 commits into from
Dec 8, 2021

Conversation

Drew-Pappas
Copy link
Contributor

@Drew-Pappas Drew-Pappas commented Dec 8, 2021 •
edited

This PR makes explicit the implicit requirement that Civis files in civis.io.civis_file_to_table must be in CSV-like format.

Closes #422

  • (For Civis employees only) Reference to a relevant ticket in the pull request title
  • Changelog entry added to CHANGELOG.md at the repo's root level
  • Description of change in the pull request description
  • If applicable, unit tests have been added and/or updated
  • The CircleCI builds have all passed

Screenshot of changes:

Screen Shot 2021-12-08 at 4 04 54 PM

@Drew-Pappas Drew-Pappas marked this pull request as ready for review December 8, 2021 21:20
@jacksonlee-civis jacksonlee-civis added this to the v1.16.0 milestone Dec 8, 2021
jacksonlee-civis
jacksonlee-civis approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@jacksonlee-civis jacksonlee-civis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! LGTM!

@jacksonlee-civis jacksonlee-civis changed the title [CIVIS-1509] improve documentation of input to civis.io.civis file to table [CIVIS-1509] DOC improve documentation of input to civis.io.civis_file_to_table Dec 8, 2021
@Drew-Pappas Drew-Pappas merged commit 09df35a into master Dec 8, 2021
@Drew-Pappas Drew-Pappas deleted the civis-1509-improve-documentation-of-input-to-civis.io.civis_file_to_table branch December 8, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacksonlee-civis jacksonlee-civis jacksonlee-civis approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Improve documentation of input to civis.io.civis_file_to_table
2 participants
@Drew-Pappas @jacksonlee-civis