[CIVIS-1822] ENH file_id_from_run_output works for all job types
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use jobs.list_runs_outputs instead of container specific command
There was a problem hiding this comment.
@KasiaHinkson Could you rebase the upstream "master" branch into your branch here? That should resolve the build failure.
|
Done, that worked. Thank you! |
jacksonlee-civis
changed the title
file_id_from_run_output works for all job types
There was a problem hiding this comment.
@KasiaHinkson Thank you for improving civis-python! Two small changes are needed (see my comments below), then this PR should be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
client.scripts.list_containers_runs_outputswithclient.jobs.list_runs_outputsincivis.io.file_id_from_run_outputso it works for all job types, not just container scripts.CHANGELOG.mdat the repo's root level