Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-1683][CIVIS-5258] FIX responses are no longer mutable; support snake_case key access for nested responses #463

Merged
merged 10 commits into from
Mar 14, 2023

Conversation

jacksonlee-civis
Copy link
Member

This PR re-implements the civis.response.Response class, in a bid to address two long-standing issues:

  • (For Civis employees only) Reference to a relevant ticket in the pull request title
  • Changelog entry added to CHANGELOG.md at the repo's root level
  • Description of change in the pull request description
  • If applicable, unit tests have been added and/or updated
  • The CircleCI builds have all passed

@jacksonlee-civis jacksonlee-civis marked this pull request as ready for review February 21, 2023 19:04
@jacksonlee-civis jacksonlee-civis added this to the v2.0.0 milestone Feb 21, 2023
Copy link

@margaretott margaretott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacksonlee-civis jacksonlee-civis merged commit 34ed2de into main Mar 14, 2023
@jacksonlee-civis jacksonlee-civis deleted the civis-1683-civis-5258-response branch March 14, 2023 14:33
@jacksonlee-civis jacksonlee-civis removed their assignment Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent snake_case vs camelCase for Response keys Make the Response object immutable
2 participants