Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-5273] MAINT Windows builds on CircleCI #480

Merged
merged 6 commits into from
May 14, 2024

Conversation

jacksonlee-civis
Copy link
Member

For CI, we used to have Windows builds through AppVeyor, but they haven't worked for a while (#279). Since CircleCI also provides Windows builds, let's just switch to CircleCI.

Resolves #279.


  • (For Civis employees only) Reference to a relevant ticket in the pull request title
  • Changelog entry added to CHANGELOG.md at the repo's root level
  • Description of change in the pull request description
  • If applicable, unit tests have been added and/or updated
  • The CircleCI builds have all passed

Copy link
Contributor

@Drew-Pappas Drew-Pappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed build-python-win on CircleCi and observed all tests passing. LGTM!

@jacksonlee-civis jacksonlee-civis merged commit b21b16f into main May 14, 2024
1 check passed
@jacksonlee-civis jacksonlee-civis deleted the civis-5273-windows-ci-builds branch May 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appveyor tests don't show up in PRs
2 participants