ENH Warn when expanding columns with many categories #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users sometimes forget to exclude columns with large numbers of categories (for example, a dataset index, or a free text response field). Give them a warning so that it's easier to diagnose if this causes errors later. The threshold is a class attribute to allow users to modify it if desired (but it's not a constructor parameter because they shouldn't want to modify it often, if ever).
|
FTR, I don't really want to see this warning. Users are responsible for knowing what is in their data. |
|
I've seen more than one case where this warning would have saved significant amounts of time. |
|
Yeah. People inspecting their data first would have done the same trick. (shrug) |
elsander
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users sometimes forget to exclude columns with large numbers of categories (for example, a dataset index, or a free text response field). Give them a warning so that it's easier to diagnose if this causes errors later. The threshold is a class attribute to allow users to modify it if desired (but it's not a constructor parameter because they shouldn't want to modify it often, if ever).
Closes #25 .