This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
BUG Parameterize CV object with random seed #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @xdavio, this looks good. Would you mind adding a test asserting we pass |
|
@wlattner I've added the tests, give it another pass? |
wlattner
suggested changes
Dec 14, 2017
glmnet/util.py
Outdated
| n_jobs, verbose): | ||
| def _score_lambda_path(est, X, y, sample_weight, relative_penalties, | ||
| n_splits, random_state, scoring, n_jobs, | ||
| verbose): |
There was a problem hiding this comment.
I think you can now remove n_splits and random_state now that cv is handled by the estimator.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #23