This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
BUG Satisfy scikit-learn Estimator checks #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 8, 2019 12:00
It looks like the calling parameters for `sklearn.utils.testing.ignore_warnings` have changed. Call it with a keyword argument instead of relying on a positional argument.
For full scikit-learn compatibility, we shouldn't set anything in the __init__ except for parameters passed into the `__init__` function. The `cv` attribute is a private internal attribute, so mark it as such.
Satisfy the scikit-learn estimator checks: Correctly handle list inputs for `sample_weights`.
This was failing on the scikit-learn check_estimator. Bring in the fix from civisanalytics#26.
This was referenced Mar 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scikit-learn
check_estimatorfunction appears to have become more comprehensive in the past year. Add fixes for the things that have changed. Includesignore_warningsfor the new function signaturesample_weightsNote that this PR does hide the previously public
cvattribute, but that attribute was introduced in PR #24 which has not yet been released.Closes #25 , #38