Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

DOC: ReStructuredText README for PyPI #36

Merged
merged 3 commits into from
Feb 21, 2018
Merged

DOC: ReStructuredText README for PyPI #36

merged 3 commits into from
Feb 21, 2018

Conversation

wlattner
Copy link
Contributor

Closes #35.

beckermr
beckermr reviewed Feb 15, 2018
View reviewed changes
README.rst Outdated

``glmnet`` depends on numpy, scikit-learn and scipy. A working Fortran
compiler is also required to build the package, for Mac users,
``brew install gcc`` will take care of this requirement.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also mention the conda forge package which works now.

@wlattner wlattner force-pushed the convert-readme branch 2 times, most recently from 0575993 to 8dace15 Compare February 21, 2018 04:42
@beckermr
Copy link

It looks like you missed changing the manifest.in file. I think setuptools includes rst by default? Otherwise I do not see how the tests would pass.

@wlattner
Copy link
Contributor Author

(╯°□°)╯︵ ┻━┻

@beckermr
Copy link

LGTM!

@beckermr beckermr merged commit 87ca3af into civisanalytics:master Feb 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@beckermr beckermr beckermr left review comments

Assignees

@wlattner wlattner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wlattner @beckermr