Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Setup #233

Closed
kitarp29 opened this issue Jun 27, 2022 · 11 comments
Closed

Logging Setup #233

kitarp29 opened this issue Jun 27, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@kitarp29
Copy link

I was looking towards to contributing to the project.
I can't seem to find any kind of Logging setup in the project.
Not a pro in Golang but surely have worked around log module and logrus module.
I know the benefits of logs. It helps a lot while debugging.
If this is something viable to be added to the project.
Please assign it to me :)
cc: @andyjeffries @DMajrekar @jaysonsantos

@kitarp29
Copy link
Author

@RealHarshThakur @alejandrojnm
If logrus seems like a good fit let me.
It has different categories for Logs and will come in real handy if you have any logging architecture setup with something like Fluentd or ELK stack
A good article on the same Here

@alejandrojnm
Copy link
Member

alejandrojnm commented Aug 24, 2022

I'm more than happy to use logrus

@kitarp29
Copy link
Author

If this is something that is needed. assign me to the issue, I will start working on it during the weekend.

@RealHarshThakur
Copy link
Member

Thanks for assiting with this @kitarp29
We'll need to make sure that our outputs are consistent from UX though. Shout out to us if you need help

@alejandrojnm
Copy link
Member

@kitarp29 it will be nice if we can run in debug mode like kubectl that shows all the trace if you pass -v 10, in that way we can debug every query made by the CLI

@alejandrojnm alejandrojnm added the enhancement New feature or request label Aug 24, 2022
@RealHarshThakur
Copy link
Member

For the initial PR though, happy to just see it be a drop-in replacement for what we have right now.

@kitarp29
Copy link
Author

Yes, @RealHarshThakur I will be making smaller commits itself so that it will be easier for the maintainers to review it.

@uzaxirr
Copy link
Member

uzaxirr commented Oct 28, 2022

@kitarp29 Can i take this forward?

@kitarp29
Copy link
Author

kitarp29 commented Oct 28, 2022

@uzaxirr I am stuck with some work in life. Surely you can take this forward.
If you have any trouble understanding the approach I took, do let me know.
I will help you in understanding.
The implementation is pretty straightforward, just replicate the work over other functions.

@uzaxirr
Copy link
Member

uzaxirr commented Oct 28, 2022

@uzaxirr I am stuck with some work in life. Surely you can take this forward. If you have any trouble understanding the approach I took, do let me know. I will help you in understanding. The implementation is pretty straightforward, just replicate the work over other functions.

Sure thing!

@uzaxirr
Copy link
Member

uzaxirr commented Oct 29, 2022

@RealHarshThakur Can you assign this to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants