Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up Logging #251

Closed
wants to merge 8 commits into from
Closed

Setting up Logging #251

wants to merge 8 commits into from

Conversation

kitarp29
Copy link

  • Logging Setup #233
    Working on this using this logrus module.
    There are multiple options and methods that logrus provides.
    Selecting the ones that the project needs is a topic of discussion,

What I have done so far:

  • Utilized the cmd module to create different forms of logs. For example, WARN, ERROR, FATAL.
  • The logs will be in JSON Format.
  • All the logs will contain information about their calling method (as in the function and the file it triggered from).

What I need help with:

  • Figuring out the main file where all these config options of logrus will be defined, I really this function should be the function that starts as soon as the project initiates.
  • Setting up locally to run and test on my system.
  • A small skim of the codebase would have been easier, but since a small codebase. I will make do anyway

Topics for discussing:

  • logrus can write generate all the logs in stdout, stderr or can be used to make .log or even .txt filled.
  • Other than FATAL, ERROR, and WARN do we need to have INFO logs as well?
  • We can add colors to logs as well, is it needed? I see there is a utility module in the project. Unsure of its usage as of now.
  • What are the fields we need in the logs?
  • Are there any other middleware we plan to include in the project for logging purposes?

cc: @alejandrojnm @RealHarshThakur @kaihoffman

Signed-off-by: kitarp29 <kitarpsinghrajpoot@gmail.com>
Signed-off-by: kitarp29 <kitarpsinghrajpoot@gmail.com>
Signed-off-by: kitarp29 <kitarpsinghrajpoot@gmail.com>
Signed-off-by: kitarp29 <kitarpsinghrajpoot@gmail.com>
Signed-off-by: kitarp29 <kitarpsinghrajpoot@gmail.com>
@kitarp29
Copy link
Author

kitarp29 commented Sep 7, 2022

@RealHarshThakur @alejandrojnm ANy updates or take on this?
I will start to apply the changes to other files as well after your green flag.

@alejandrojnm
Copy link
Member

Can you show the out put ???

@kitarp29
Copy link
Author

kitarp29 commented Sep 7, 2022

Hi, @alejandrojnm I don't have my laptop right now.
It won't be much different, to be honest. It will be a simple JSON, I will share as I get time.

@haardikdharma10
Copy link
Contributor

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants