Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix volume ls command #239

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Fix volume ls command #239

merged 1 commit into from
Aug 10, 2022

Conversation

RealHarshThakur
Copy link
Member

@RealHarshThakur RealHarshThakur commented Aug 10, 2022 •
edited
Loading

Bug: Command failed when it found a volume attached to a cluster worker node as it searched for instance in /v2/instances.

PR does 3 things:

  • Fixed the original bug.
  • Performance improvement by listing resources and looping through them rather than making network calls.
  • Update Go version to 1.17

Fix volume ls command
d63cd4b 
Signed-off-by: Harsh Thakur <harsh@civo.com>
@alejandrojnm
Copy link
Member

can we do this on the API side ???

vishalanarase
vishalanarase approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@vishalanarase vishalanarase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RealHarshThakur RealHarshThakur merged commit bc83b75 into master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrojnm alejandrojnm alejandrojnm approved these changes

@vishalanarase vishalanarase vishalanarase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RealHarshThakur @alejandrojnm @vishalanarase