Suggest next available size when creating an object store #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is missing tests and docs |
SaptarshiSarkar12
approved these changes
Sep 14, 2022
|
Also, please anyone add docs for it as mentioned by @DMajrekar |
alessandroargentieri
requested changes
Sep 20, 2022
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
A couple of unit test would assure everything works fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minimum size to create an Object Store is 500 and they should be created in multiples of 500 GB. If the user passes a size > 500, which is not a multiple, the CLI will suggest the next available size.