Fix slow firewall list command #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/firewall/firewall_list.go
Outdated
| @@ -1,6 +1,7 @@ | |||
| package firewall | |||
|
|
|||
| import ( | |||
| "github.com/civo/civogo" | |||
There was a problem hiding this comment.
Import orders are wrong
cmd/firewall/firewall_list.go
Outdated
| ow := utility.NewOutputWriter() | ||
| for _, firewall := range firewalls { | ||
| network, _ := client.FindNetwork(firewall.NetworkID) | ||
| for _, network = range networks { |
There was a problem hiding this comment.
I would suggest before looping over firewalls , loop over Networks to create a "map[networkID]:networkLabel" .
When you run the firewall loop, you can directly use it that map to give out network name on L66 rn
RealHarshThakur
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#303