Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use simplified 1.2.0 cert-manager installation instead #160

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

sr229
Copy link
Contributor

@sr229 sr229 commented Mar 1, 2021

Thank you for wanting to submit a Pull Request to the Civo Kubernetes Marketplace repository!

If your pull request is to submit a new application to the marketplace, please answer the following questions:

  • Have you followed the guidelines in our Contributing document in setting up the application?
  • Have you checked that the application your submission is proposing to add does not yet exist on the Marketplace, or as a pull request to be processed?
  • Have you tested your application on the Civo managed Kubernetes service? Please include a screenshot.
  • Can you confirm that the software you are submitting licensed for use in a publicly-available Kubernetes marketplace?

If your pull request concerns an existing Marketplace application, please make sure you have:

  • Notified the Maintainer of the application in this pull request so that they are aware of your proposal.
  • Outlined the changes you are proposing, and the reasons these are required (e.g. stability, compatibility with new versions of Kubernetes implementations, etc).
  • Tested that the application works with the proposed updates applied (including a screenshot)

Signed-off-by: GitHub <noreply@github.com>
@DoNnMyTh
Copy link
Contributor

DoNnMyTh commented Mar 1, 2021

image
image
image
Runs fine on my side

Copy link
Contributor

@DoNnMyTh DoNnMyTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment works fine as independent command but cant confirm via marketplace.

@sr229
Copy link
Contributor Author

sr229 commented Mar 2, 2021

Deployment works fine as independent command but cant confirm via marketplace.

it should work as-is though I'm not so certain how the platform handles this.

@DoNnMyTh
Copy link
Contributor

DoNnMyTh commented Mar 2, 2021

it's on @saiyam1814 :)

@saiyam1814
Copy link
Contributor

lgtm

@saiyam1814 saiyam1814 merged commit 62a2aac into civo:master Mar 3, 2021
@sr229 sr229 deleted the cert-manager/1.2.0 branch March 3, 2021 11:22
@sr229 sr229 mentioned this pull request Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants