Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use non-production API server URL #103

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

zulh-civo
Copy link
Member

This PR will allow us to use non-production API server URL e.g. staging/dev servers to test our Terraform provider. Here is quick guide for it.

To use other server URL

$ export CIVO_API_URL="https://example.com"
$ tf plan|apply|destroy

To use production server URL again

$ unset CIVO_API_URL
$ tf plan|apply|destroy

@zulh-civo zulh-civo self-assigned this Nov 1, 2021
@zulh-civo zulh-civo added the setup label Nov 1, 2021
@zulh-civo
Copy link
Member Author

@alejandrojnm could you please review this?

@alejandrojnm
Copy link
Member

Look good to me, but I think it will be nice if you can use this too in the provider file, what do you think ?

@zulh-civo
Copy link
Member Author

How?

@alejandrojnm
Copy link
Member

added a new field here

like api_url with the same behaviour of region or token

@zulh-civo
Copy link
Member Author

I doubt that. It's only useful for project maintainers like us. If we add support for api_url (even if it's an optional field), I'm afraid it will confuse our users. Plus, we don't see any requests for such use case, yet. Let's revisit it when we start seeing requests from our users (GitHub issue/Slack conversation/etc).

@zulh-civo zulh-civo merged commit b654130 into master Nov 8, 2021
@alejandrojnm alejandrojnm deleted the clients-for-testing branch November 10, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants