change in private_ipv4 on instance value requires the replacement #255
Conversation
| ip, err := apiClient.FindIP(oldReservedIP.(string)) | ||
| if err != nil { | ||
| if errors.Is(err, civogo.ZeroMatchesError) { | ||
| return diag.Errorf("sorry there is no %s IP in your account", oldReservedIP) |
There was a problem hiding this comment.
I would suggest to rework and reword this. Something like "Sorry, there is no IP that matches %s in in this network" ?
I suggest "network" rather than account as these are network-specific, right?
| if errors.Is(err, civogo.ZeroMatchesError) { | ||
| return diag.Errorf("sorry there is no %s IP in your account", oldReservedIP) | ||
| } else if errors.Is(err, civogo.MultipleMatchesError) { | ||
| return diag.Errorf("sorry we found more than one IP with that value in your account") |
There was a problem hiding this comment.
Change this to be "Sorry, more than one IP with that value matches this request" or something?
| } else if errors.Is(err, civogo.MultipleMatchesError) { | ||
| return diag.Errorf("sorry we found more than one IP with that value in your account") | ||
| } else { | ||
| return diag.Errorf("error finding IP %s: %s", oldReservedIP, err) |
|
|
||
| _, err = apiClient.UnassignIP(ip.ID, apiClient.Region) | ||
| if err != nil { | ||
| return diag.Errorf("[ERR] an error occurred while unassigning reserved IP %s from instance %s: %s", ip.ID, instance.ID, err) |
There was a problem hiding this comment.
Any reason why this one has "[ERR]" as the prefix to the message and some others don't?
| if err != nil { | ||
| return diag.Errorf("[ERR] an error occurred while unassigning reserved IP %s from instance %s: %s", ip.ID, instance.ID, err) | ||
| } | ||
| log.Printf("[INFO] unassigned reserved IP %s from the instance %s", oldReservedIP, d.Id()) |
There was a problem hiding this comment.
And this one - why "[INFO]" when other messages are not always prefaced with a classification like this?
| if errors.Is(err, civogo.ZeroMatchesError) { | ||
| return diag.Errorf("sorry there is no %s IP in your account", newReservedIP) | ||
| } else if errors.Is(err, civogo.MultipleMatchesError) { | ||
| return diag.Errorf("sorry we found more than one IP with that value in your account") |
There was a problem hiding this comment.
See my other comment re multiple matches and rewording that
| ip, err := apiClient.FindIP(newReservedIP.(string)) | ||
| if err != nil { | ||
| if errors.Is(err, civogo.ZeroMatchesError) { | ||
| return diag.Errorf("sorry there is no %s IP in your account", newReservedIP) |
There was a problem hiding this comment.
Capitalize and add comma: "Sorry, there is no IP matching %s in this network" assuming it's network, not account-specific?
fixes: #247
As it is an immutable field via api, an replacement prompt will occur when change in this value is detected.