This repository has been archived by the owner on Aug 29, 2020. It is now read-only.
Only scale by visible network values #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of just the entries displayed. This meant that high transmission or reception rates would cause the scaling to drown out any small entries even if the high rates were not being displayed. This change passes in just the amount of samples needed to fill the block instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the scaling would be based on all network entries recorded instead of just the network entries displayed. This meant that high transmission or reception rates would cause the scaling to drown out any small entries even if the high rates were not being displayed. This change passes in just the amount of samples needed to fill the block and let's the
Sparklinecalculate themaxinternally.Luckily all the hard work seemed to be done already so this change was a joy to make.
Possibly related (#90)