Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CharacterName aspect element #77

Closed
cjcodeproj opened this issue Dec 23, 2022 · 2 comments
Closed

Handle CharacterName aspect element #77

cjcodeproj opened this issue Dec 23, 2022 · 2 comments
Assignees
@cjcodeproj
Labels
enhancement New feature or request

Comments

@cjcodeproj
Copy link
Owner

Update the CharacterName() class to handle the new <aspect> element as described this schema ticket:

cjcodeproj/vtmedia-schema#46

Also, take into consideration that the <variant> and <aspect> elements are intended to work with a <title> element, which is handled by the CharacterTitle() class, but the code does not currently support them properly.
@cjcodeproj cjcodeproj added bug Something isn't working enhancement New feature or request labels Dec 23, 2022
@cjcodeproj cjcodeproj self-assigned this Dec 23, 2022
@cjcodeproj cjcodeproj removed the bug Something isn't working label Dec 23, 2022
@cjcodeproj
Copy link
Owner Author

Commit.

bffac77

@cjcodeproj
Copy link
Owner Author

Closing notes:

  • Added one unit test
  • Going to handle the bug with the CharacterTitle class under a different ticket.

@cjcodeproj cjcodeproj mentioned this issue Dec 23, 2022
Closed
This was referenced Mar 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjcodeproj cjcodeproj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjcodeproj