Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtpfs.c: always open device_number=0 instead of random one #4

Merged
merged 1 commit into from Jan 3, 2016
Merged

mtpfs.c: always open device_number=0 instead of random one #4

merged 1 commit into from Jan 3, 2016

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Aug 7, 2015

'int i;' was uinitialized and used in
'device = LIBMTP_Open_Raw_Device(&rawdevices[i]);'

The problem was found out by LE GARREC Vincent
and manifested as a SIGSEGV ( described in
https://bugs.gentoo.org/show_bug.cgi?id=556690 )

Signed-off-by: Sergei Trofimovich siarheit@google.com

    'int i;' was uinitialized and used in
    'device = LIBMTP_Open_Raw_Device(&rawdevices[i]);'

The problem was found out by LE GARREC Vincent
and manifested as a SIGSEGV ( described in
https://bugs.gentoo.org/show_bug.cgi?id=556690 )

Signed-off-by: Sergei Trofimovich <siarheit@google.com>
@wking
Copy link
Contributor

wking commented Jan 3, 2016

It looks like this PR conflicts now that my PRs have landed. It should be a fairly straightforward rebase to put it on top of my changes though, and once this lands cjd/master will have caught up to wking/wtk.

@cjd cjd merged commit 1071f6b into cjd:master Jan 3, 2016
@cjd
Copy link
Owner

cjd commented Jan 3, 2016

This is merged in now

@wking
Copy link
Contributor

wking commented Jan 4, 2016

On Sun, Jan 03, 2016 at 03:54:53PM -0800, Chris Debenham wrote:

This is merged in now

It 1071f6b has some different whitespace than:

$ indent --ignore-profile --gnu-style *.c *.h

recommends, so it's undoing part of #5. Maybe a Makefile rule for
formatting would help? Or maybe it's fine to just let things go again
and have another style-consistency flag-day if/when it becomes
sufficiently confusing ;).

@cjd
Copy link
Owner

cjd commented Jan 7, 2016

I've just made commit 9e11ae9 which fixes up the formatting to match the rest

@wking
Copy link
Contributor

wking commented Jan 7, 2016

On Wed, Jan 06, 2016 at 04:11:32PM -0800, Chris Debenham wrote:

I've just made commit 9e11ae9 which
fixes up the formatting to match the rest

:). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants