Skip to content

Commit

Permalink
Merge pull request eclipse#6779 from VermaSh/replace_zNext_with_z16
Browse files Browse the repository at this point in the history
Replace zNext with z16
  • Loading branch information
babsingh committed Nov 28, 2022
2 parents 8d7fef1 + e355ae4 commit acdbafc
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 10 deletions.
1 change: 1 addition & 0 deletions compiler/control/OMROptions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,7 @@ TR::OptionTable OMR::Options::_jitOptions[] = {
{"disableZ13", "O\tdisable z13 support", SET_OPTION_BIT(TR_DisableZ13), "F"},
{"disableZ14", "O\tdisable z14 support", SET_OPTION_BIT(TR_DisableZ14), "F"},
{"disableZ15", "O\tdisable z15 support", SET_OPTION_BIT(TR_DisableZ15), "F"},
{"disableZ16", "O\tdisable z16 support", SET_OPTION_BIT(TR_DisableZ16), "F"},
{"disableZ196", "O\tdisable z196 support", SET_OPTION_BIT(TR_DisableZ196), "F"},
{"disableZArraySetUnroll", "O\tdisable arraySet unrolling on 390.", SET_OPTION_BIT(TR_DisableZArraySetUnroll), "F"},
{"disableZealousCodegenOpts", "O\tdisable use of zealous codegen optimizations.", SET_OPTION_BIT(TR_DisableZealousCodegenOpts), "F"},
Expand Down
2 changes: 1 addition & 1 deletion compiler/control/OMROptions.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ enum TR_CompilationOptions
TR_EnableLowerCompilationLimitsDecisionMaking
= 0x00000020 + 8,
TR_DisableDirectToJNI = 0x00000040 + 8,
// Available = 0x00000080 + 8,
TR_DisableZ16 = 0x00000080 + 8,
TR_EmitExecutableELFFile = 0x00000100 + 8,
TR_JITServerFollowRemoteCompileWithLocalCompile = 0x00000200 + 8,
TR_EnableClassChainValidationCaching = 0x00000800 + 8,
Expand Down
2 changes: 1 addition & 1 deletion compiler/z/codegen/OMRInstOpCode.enum
Original file line number Diff line number Diff line change
Expand Up @@ -1173,7 +1173,7 @@
VSRD, // vector shift right double by bit
VSTRS, // vector string search

/* zNext Instructions */
/* z16 Instructions */
VCLZDP, // VECTOR COUNT LEADING ZERO DIGITS
VPKZR, // VECTOR PACK ZONED REGISTER
VUPKZL, // VECTOR UNPACK ZONED LOW
Expand Down
8 changes: 4 additions & 4 deletions compiler/z/codegen/OMRInstOpCodeProperties.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15996,7 +15996,7 @@
/* .opcode[0] = */ 0xE6,
/* .opcode[1] = */ 0x51,
/* .format = */ VRRk_FORMAT,
/* .minimumALS = */ OMR_PROCESSOR_S390_ZNEXT,
/* .minimumALS = */ OMR_PROCESSOR_S390_Z16,
/* .properties = */ S390OpProp_SetsOperand1 |
S390OpProp_UsesM3
},
Expand All @@ -16008,7 +16008,7 @@
/* .opcode[0] = */ 0xE6,
/* .opcode[1] = */ 0x70,
/* .format = */ VRIf_FORMAT,
/* .minimumALS = */ OMR_PROCESSOR_S390_ZNEXT,
/* .minimumALS = */ OMR_PROCESSOR_S390_Z16,
/* .properties = */ S390OpProp_SetsCC |
S390OpProp_SetsOperand1 |
S390OpProp_UsesM5
Expand All @@ -16021,7 +16021,7 @@
/* .opcode[0] = */ 0xE6,
/* .opcode[1] = */ 0x5C,
/* .format = */ VRRk_FORMAT,
/* .minimumALS = */ OMR_PROCESSOR_S390_ZNEXT,
/* .minimumALS = */ OMR_PROCESSOR_S390_Z16,
/* .properties = */ S390OpProp_SetsOperand1 |
S390OpProp_UsesM3
},
Expand All @@ -16033,7 +16033,7 @@
/* .opcode[0] = */ 0xE6,
/* .opcode[1] = */ 0x54,
/* .format = */ VRRk_FORMAT,
/* .minimumALS = */ OMR_PROCESSOR_S390_ZNEXT,
/* .minimumALS = */ OMR_PROCESSOR_S390_Z16,
/* .properties = */ S390OpProp_SetsOperand1 |
S390OpProp_UsesM3
},
8 changes: 7 additions & 1 deletion compiler/z/env/OMRCPU.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ OMR::Z::CPU::detect(OMRPortLibrary * const omrPortLib)
omrsysinfo_processor_set_feature(&processorDescription, OMR_FEATURE_S390_VECTOR_PACKED_DECIMAL_ENHANCEMENT_FACILITY, FALSE);
}

if (processorDescription.processor < OMR_PROCESSOR_S390_ZNEXT)
if (processorDescription.processor < OMR_PROCESSOR_S390_Z16)
{
omrsysinfo_processor_set_feature(&processorDescription, OMR_FEATURE_S390_VECTOR_PACKED_DECIMAL_ENHANCEMENT_FACILITY_2, FALSE);
}
Expand Down Expand Up @@ -141,6 +141,9 @@ OMR::Z::CPU::isAtLeastOldAPI(OMRProcessorArchitecture p)
case OMR_PROCESSOR_S390_Z15:
ans = self()->getSupportsArch(TR::CPU::z15);
break;
case OMR_PROCESSOR_S390_Z16:
ans = self()->getSupportsArch(TR::CPU::z16);
break;
case OMR_PROCESSOR_S390_ZNEXT:
ans = self()->getSupportsArch(TR::CPU::zNext);
break;
Expand Down Expand Up @@ -241,6 +244,9 @@ OMR::Z::CPU::getProcessorName()
case OMR_PROCESSOR_S390_Z15:
result = "z15";
break;
case OMR_PROCESSOR_S390_Z16:
result = "z16";
break;
case OMR_PROCESSOR_S390_ZNEXT:
result = "zNext";
break;
Expand Down
1 change: 1 addition & 0 deletions compiler/z/env/OMRCPU.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class OMR_EXTENSIBLE CPU : public OMR::CPU
z13,
z14,
z15,
z16,
zNext,
};

Expand Down
3 changes: 2 additions & 1 deletion include_core/omrport.h
Original file line number Diff line number Diff line change
Expand Up @@ -1363,6 +1363,7 @@ typedef enum OMRProcessorArchitecture {
OMR_PROCESSOR_S390_Z13,
OMR_PROCESSOR_S390_Z14,
OMR_PROCESSOR_S390_Z15,
OMR_PROCESSOR_S390_Z16,
OMR_PROCESSOR_S390_ZNEXT,
OMR_PROCESSOR_S390_LAST = OMR_PROCESSOR_S390_ZNEXT,

Expand Down Expand Up @@ -1609,7 +1610,7 @@ typedef struct OMRProcessorDesc {
/* STFLE bit 152 - Vector packed decimal enhancement facility */
#define OMR_FEATURE_S390_VECTOR_PACKED_DECIMAL_ENHANCEMENT_FACILITY 152

/* zNext facilities */
/* z16 facilities */

/* STFLE bit 192 - Vector-Packed-Decimal-Enhancement Facility 2 */
#define OMR_FEATURE_S390_VECTOR_PACKED_DECIMAL_ENHANCEMENT_FACILITY_2 192
Expand Down
4 changes: 2 additions & 2 deletions port/unix/omrsysinfo.c
Original file line number Diff line number Diff line change
Expand Up @@ -1704,7 +1704,7 @@ omrsysinfo_get_s390_description(struct OMRPortLibrary *portLibrary, OMRProcessor
}
}

/* zNext facility and processor detection */
/* z16 facility and processor detection */

if (omrsysinfo_test_stfle(portLibrary, OMR_FEATURE_S390_VECTOR_PACKED_DECIMAL_ENHANCEMENT_FACILITY_2)) {
#if defined(J9ZOS390)
Expand All @@ -1715,7 +1715,7 @@ omrsysinfo_get_s390_description(struct OMRPortLibrary *portLibrary, OMRProcessor
{
omrsysinfo_set_feature(desc, OMR_FEATURE_S390_VECTOR_PACKED_DECIMAL_ENHANCEMENT_FACILITY_2);

desc->processor = OMR_PROCESSOR_S390_ZNEXT;
desc->processor = OMR_PROCESSOR_S390_Z16;
}
}

Expand Down

0 comments on commit acdbafc

Please sign in to comment.