Replace zNext with z16 #6779
Replace zNext with z16 #6779
Conversation
VermaSh
requested review from
charliegracie,
youngar,
rwy7,
babsingh,
fjeremic,
0xdaryl and
mstoodle
as code owners
|
I have launched a personal build, will post an update once it passes |
|
Both builds passed without failures. @r30shah this is ready for review |
|
@VermaSh Thanks a lot for making the changes. Is there any OpenJ9 change that depends on changes from this PR as well? |
|
@r30shah Here's the openj9 PR eclipse-openj9/openj9#16140 |
| @@ -141,8 +141,8 @@ OMR::Z::CPU::isAtLeastOldAPI(OMRProcessorArchitecture p) | |||
| case OMR_PROCESSOR_S390_Z15: | |||
| ans = self()->getSupportsArch(TR::CPU::z15); | |||
| break; | |||
| case OMR_PROCESSOR_S390_ZNEXT: | |||
There was a problem hiding this comment.
We need to add Z16 here, but should not delete the ZNEXT here.
There was a problem hiding this comment.
I have fixed it in my latest commit.
Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
VermaSh
force-pushed
the
replace_zNext_with_z16
branch
from
dc9fcd6
to
e355ae4
Compare
|
FYI: This and eclipse-openj9/openj9#16140 must be picked together by the release for z16 exploits to remain usable. Having just this would result in the z16 exploits becoming disabled. Having just openj9 changes would break the build. |
|
Jenkins build zos,zlinux |
|
@pshipton @joransiu What do you think about @VermaSh's comment in #6779 (comment) ? Do we want to get both PR in together or it will be OK if we have a short period of time where builds would have z16 changes disabled till OpenJ9 PR is merged? |
|
It's better to do an OpenJ9 coordinated merge/OMR promotion. There is no problem merging the OMR change (although it will block other OMR changes promoting to OpenJ9 until it can promote), but the new OMR level needs to go through the OpenJ9 acceptance build for OMR, which can take 5-6 hours (for a full build of all platforms). OpenJ9 builds will be broken during this waiting time, unless a coordinated merge/OMR promotion is done. |
|
@pshipton to be clear, changes in this PR will not break the OpenJ9 builds. Without OpenJ9 PR, for that brief 5-6 hour period, JDK builds would have JIT exploitation of z16 disabled. |
|
Oh ok, no coordinated merge required then. This should be merged when ready and it should promote with the next OMR acceptance, or we can run a custom one. |
|
@VermaSh I forgot, anything remained for this PR? We are done with all the personal sanity tests right? If not then we should coordinate on getting this in. |
|
Just merge it and I'll get it in. |
@r30shah Nothing left for this PR. This is ready to be merged |
|
Jenkins build zos,zlinux |
|
I'm not an OMR committer ... |
|
Thanks a lot @babsingh for merging this one. |
Signed-off-by: Shubham Verma shubhamv.sv@gmail.com