-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
Can anybody please merge this? |
return UIApplication.shared.value(forKey: s+b+w) as? UIWindow | ||
if #available(iOS 13, *) { | ||
return nil | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the sidemenu display correctly in iOS13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it does just as in iOS12 (meaning that it doesn't crash anymore but still doesn't fill the screen height when running on iPhone X type devices.
EDITED: I just realized that it doesn't fill the status bar either in iOS13 with this fix. Still better than a crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I think there's another fork of this project that fixes the iPhone X issue.
Can you show me a screenshot of this is in iOS 13? The current example project needs to be updated and isn't displaying correctly and I no longer use this sidemenu in any of the projects I'm working on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok going to merge and I'll look into the iPhone X issues with this fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fix crash on iOS 13 as iOS 13 no longer supports access to StatusBarWindow.