Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Fix crash on iOS 13 #2

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Fix crash on iOS 13 #2

merged 1 commit into from
Oct 12, 2019

Conversation

mobinzk
Copy link

@mobinzk mobinzk commented Sep 25, 2019

This will fix crash on iOS 13 as iOS 13 no longer supports access to StatusBarWindow.

@ghost
Copy link

ghost commented Oct 12, 2019

Can anybody please merge this?

return UIApplication.shared.value(forKey: s+b+w) as? UIWindow
if #available(iOS 13, *) {
return nil
} else {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the sidemenu display correctly in iOS13?

Copy link

@ghost ghost Oct 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it does just as in iOS12 (meaning that it doesn't crash anymore but still doesn't fill the screen height when running on iPhone X type devices.
EDITED: I just realized that it doesn't fill the status bar either in iOS13 with this fix. Still better than a crash.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I think there's another fork of this project that fixes the iPhone X issue.

Can you show me a screenshot of this is in iOS 13? The current example project needs to be updated and isn't displaying correctly and I no longer use this sidemenu in any of the projects I'm working on.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de pantalla 2019-10-12 a las 18 19 11

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok going to merge and I'll look into the iPhone X issues with this fork.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great. Thank you.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmvz3 @richieWave Is this what you want for iPhone X: #4

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmvz3 @richieWave Is this what you want for iPhone X: #4

Yes. That looks great. Thank you!

@cjlarsen cjlarsen merged commit 2030c35 into cjlarsen:master Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants