Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code freeze] Sprint-2 #692

Closed
wants to merge 3 commits into from
Closed

[Code freeze] Sprint-2 #692

wants to merge 3 commits into from

Conversation

cmltaWt0
Copy link
Collaborator

Features

  • CR-12 TZ improvements
  • CR-13 The TZ isn't updated when login through LTI

alexbojko and others added 3 commits October 30, 2017 17:22
… user profile.

Now field timezone has choices with all avialable timezones, and in case for old profiles with already set incorrect tz it will use default TZ from settings file.
fix(issue#687): Fix for issue #687 to avoid incorrect timezone in user profile.
… exist) and store tz (#691)

* fix(issue#686): When user login through lti we create profile (if not exist) and store tz

When user log in through lti - get user's location using pygeoip and remember timezon in Profile.timezone

* Added lost import of pytz module
@cmltaWt0 cmltaWt0 self-assigned this Nov 14, 2017
@coveralls
Copy link

coveralls commented Nov 14, 2017

Coverage Status

Coverage decreased (-0.02%) to 83.173% when pulling 779ad2a on development into 5e853d3 on master.

@codecov-io
Copy link

codecov-io commented Nov 14, 2017

Codecov Report

Merging #692 into master will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   83.19%   83.17%   -0.02%     
==========================================
  Files          69       69              
  Lines        6116     6127      +11     
==========================================
+ Hits         5088     5096       +8     
- Misses       1028     1031       +3
Impacted Files Coverage Δ
mysite/accounts/models.py 97.43% <100%> (+5.76%) ⬆️
mysite/lti/views.py 94.77% <100%> (+0.07%) ⬆️
mysite/analytics/tasks.py 28.16% <14.28%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e853d3...779ad2a. Read the comment docs.

Copy link
Collaborator

@alexbojko alexbojko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmltaWt0 cmltaWt0 closed this Nov 14, 2017
@cmltaWt0 cmltaWt0 deleted the development branch November 14, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants