Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mypy configuration into pyproject.toml #935

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Move mypy configuration into pyproject.toml #935

merged 3 commits into from
Jun 15, 2021

Conversation

yeskunall
Copy link
Contributor

Hey! Thanks for this dope cookiecutter template. Let me know if I need to make any changes before this can be merged.

❤️


Closes #917

Copy link
Owner

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

I'll merge the Dependabot update for mypy first, will ping you to rebase when that's done.

Update: It turns out that we need to update sphinx-click first, then click, then mypy (while installing types-click into the mypy session).

@cjolowicz cjolowicz added the ci Changes to CI configuration files and scripts label Jun 15, 2021
@cjolowicz
Copy link
Owner

cjolowicz commented Jun 15, 2021

@yeskunall Can you rebase on master? It's already on the latest mypy version.

Update: Never mind, already merged master into your branch.

@cjolowicz cjolowicz added this to the 2021.6.15 milestone Jun 15, 2021
@cjolowicz cjolowicz merged commit fca8445 into cjolowicz:main Jun 15, 2021
@cjolowicz cjolowicz mentioned this pull request Jun 15, 2021
@yeskunall
Copy link
Contributor Author

@cjolowicz you move quickly! Just got off work to see this has already been merged and made part of a new release. Once again, thanks for your work on this. I actually first came across your project on awesome-pyproject and then went through your article. Very informative!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI configuration files and scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move mypy configuration to pyproject.toml
2 participants