Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ENV\Library\bin to $PATH #11

Merged
merged 1 commit into from Apr 22, 2016
Merged

add ENV\Library\bin to $PATH #11

merged 1 commit into from Apr 22, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2016

For library like numpy, we also need to include Library\bin to $PATH

@ghost ghost mentioned this pull request Apr 21, 2016
@cjrh
Copy link
Owner

cjrh commented Apr 22, 2016

Hi @LexSong

Here is a screenshot of the folders inside one of my directories (on OS X):

image

There is no Library folder. It seems like the patch is Windows-specific. Could you change the code to alter the path depending on whether the current OS is Windows?

@ghost
Copy link
Author

ghost commented Apr 22, 2016

It already is, the patch is under line 140, which is

 if has("win32") || has("win64")

@cjrh
Copy link
Owner

cjrh commented Apr 22, 2016

(Oops, good point!)

Thanks for your patch!

@cjrh cjrh merged commit 3f458a2 into cjrh:master Apr 22, 2016
@ghost
Copy link
Author

ghost commented Apr 22, 2016

glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants