Skip to content

Commit

Permalink
[#1505] Remove assertions that group_member_create was called in the …
Browse files Browse the repository at this point in the history
…tests

If user_invite fails when group_member_create fails, and succeeds when
group_member_create succeeds, there's no need to assert that
group_member_create was actually called.
  • Loading branch information
vitorbaptista authored and amercader committed Jun 19, 2014
1 parent b6dd902 commit 61dc3a4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ckan/new_tests/logic/auth/test_create.py
Expand Up @@ -25,8 +25,6 @@ def test_user_invite_delegates_correctly_to_group_member_create(self, gmc):
'auth_user_obj': user
}
data_dict = {'group_id': 42}
group_member_create_data_dict = data_dict.copy()
group_member_create_data_dict['id'] = data_dict['group_id']

gmc.return_value = {'success': False}
nose.tools.assert_raises(logic.NotAuthorized, helpers.call_auth,
Expand All @@ -35,5 +33,3 @@ def test_user_invite_delegates_correctly_to_group_member_create(self, gmc):
gmc.return_value = {'success': True}
result = helpers.call_auth('user_invite', context=context, **data_dict)
assert result is True

gmc.assert_called_twice_with(context, group_member_create_data_dict)

0 comments on commit 61dc3a4

Please sign in to comment.