Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Add Dataset" button to user's and group's page #2794

Closed
vitorbaptista opened this issue Dec 17, 2015 · 5 comments
Closed

Add "Add Dataset" button to user's and group's page #2794

vitorbaptista opened this issue Dec 17, 2015 · 5 comments

Comments

@vitorbaptista
Copy link
Contributor

As far as I could see, every page which list datasets have the "Add Dataset" button, as:

Search datasets

search datasets

Organization's page

organization page

User's dashboard

user dashboard

The only pages that list datasets and don't add these links are:

User's page

users page

Group's page

group page

This feels inconsistent, so I would suggest adding to those places as well.

@vitorbaptista
Copy link
Contributor Author

The code that adds the "Add Datasets" buttons is repeated in each place as well, so I would suggest extracting that to a snippet. This way, it can be easily overwritten by templates/extensions (I'm doing that on https://github.com/ckan/ckanext-datapackager to add a "Import Data Package" button)

@rossjones
Copy link
Contributor

@vitorbaptista Can I assign this to you for a PR?

@vitorbaptista
Copy link
Contributor Author

@rossjones sure! 👍

Engerrs pushed a commit to Engerrs/ckan that referenced this issue May 30, 2017
@Engerrs
Copy link
Member

Engerrs commented May 30, 2017

Hi @amercader, I've added a PR for this one.

smotornyuk added a commit that referenced this issue Jul 11, 2017
…d-user-pages

[#2794] Moved Add dataset button to snippet
EnTeQuAk pushed a commit to EnTeQuAk/ckan that referenced this issue May 30, 2018
@kmbn
Copy link
Contributor

kmbn commented Jan 22, 2019

We decided to close old issues that are not actively worked on so that we can focus our effort and attention on issues affecting the current versions of CKAN.

If this issue is still affecting the version of CKAN you're working with now, please feel free to comment or reopen the issue.

If you do reopen this issue, please update it with new details. One reason it might not have been resolved in the past is that it wasn't clear how a contributor could address the issue.

@kmbn kmbn closed this as completed Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants