Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckanext tests fail when ran together with ckan's #299

Closed
vitorbaptista opened this issue Jan 24, 2013 · 2 comments
Closed

ckanext tests fail when ran together with ckan's #299

vitorbaptista opened this issue Jan 24, 2013 · 2 comments
Assignees
@vitorbaptista

Comments

@vitorbaptista
Copy link
Contributor

No description provided.

@ghost ghost assigned vitorbaptista Jan 24, 2013
vitorbaptista added a commit that referenced this issue Jan 24, 2013
@vitorbaptista
[#299] Clear up changes to Pylons' config between tests
451ddc1 
We also, instead of always loading test.ini in these tests, we use whatever Pylons loaded.
vitorbaptista added a commit that referenced this issue Jan 24, 2013
@vitorbaptista
[#299] Reload AuthFunctions if couldn't find the action we're looking…
3848cb7 
… for

The problem I found was when you're testing a bunch of things
sequentially. Then, the first time that method is called, it
loads all known AuthFunctions and puts into a cache. Then it
only checks that cache.

But what happens if some code, after this has happened, adds
a new AuthFunction? It never gets added to the cache.

With this change, if we have the requested function on cache,
we use it. If not, we refresh the cache and see if something
changed.
vitorbaptista added a commit that referenced this issue Jan 24, 2013
@vitorbaptista
[#299] Clear test data after each test is run
729a634 
This might not be the best way to do it. It's too repetitive, but it's
better than leaving trash behind.

We might investigate running the tests inside a transaction, and rolling
back when we're done (is it done already?).
vitorbaptista added a commit that referenced this issue Jan 24, 2013
@vitorbaptista
[#299] Run ckan and ckanext tests on Travis
2fe6add
vitorbaptista added a commit that referenced this issue Jan 24, 2013
@vitorbaptista
[#299] Fix ckanext.{json,pdf,recline}preview tests
fa4e775 
The problem is that we were looking for each *_preview.js, when the included
files are already minified (*_preview.min.js).
@domoritz
Copy link
Contributor

Partially fixed in #290

domoritz pushed a commit to domoritz/ckan that referenced this issue Jan 28, 2013
@vitorbaptista @domoritz
[ckan#299] Clear test data after each test is run
da1a867 
This might not be the best way to do it. It's too repetitive, but it's
better than leaving trash behind.

We might investigate running the tests inside a transaction, and rolling
back when we're done (is it done already?).

Conflicts:
	ckanext/jsonpreview/tests/test_preview.py
	ckanext/pdfpreview/tests/test_preview.py
	ckanext/reclinepreview/tests/test_preview.py
vitorbaptista added a commit that referenced this issue Feb 5, 2013
@vitorbaptista
[#299] Clear up changes to Pylons' config between tests
645e2d7 
We also, instead of always loading test.ini in these tests, we use whatever Pylons loaded.
vitorbaptista added a commit that referenced this issue Feb 5, 2013
@vitorbaptista
[#299] Reload AuthFunctions if couldn't find the action we're looking…
1684972 
… for

The problem I found was when you're testing a bunch of things
sequentially. Then, the first time that method is called, it
loads all known AuthFunctions and puts into a cache. Then it
only checks that cache.

But what happens if some code, after this has happened, adds
a new AuthFunction? It never gets added to the cache.

With this change, if we have the requested function on cache,
we use it. If not, we refresh the cache and see if something
changed.
vitorbaptista added a commit that referenced this issue Feb 5, 2013
@vitorbaptista
[#299] Clear test data after each test is run
f87ebf4 
This might not be the best way to do it. It's too repetitive, but it's
better than leaving trash behind.

We might investigate running the tests inside a transaction, and rolling
back when we're done (is it done already?).
vitorbaptista added a commit that referenced this issue Feb 5, 2013
@vitorbaptista
[#299] Run ckan and ckanext tests on Travis
7496756
vitorbaptista added a commit that referenced this issue Feb 5, 2013
@vitorbaptista
[#299] Fix ckanext.{json,pdf,recline}preview tests
efc7472 
The problem is that we were looking for each *_preview.js, when the included
files are already minified (*_preview.min.js).
kindly added a commit that referenced this issue Feb 5, 2013
@kindly @vitorbaptista
#299 clear action cache when plugin loads
b653916
kindly added a commit that referenced this issue Feb 5, 2013
@kindly @vitorbaptista
#299 unload and load datastore plugin at correct times
c5f5551
vitorbaptista added a commit that referenced this issue Feb 5, 2013
@vitorbaptista
[#299] Don't call WHERE statements if there're no terms
b874c3b 
This removes the following warning:

/home/vagrant/pyenv/local/lib/python2.7/site-packages/sqlalchemy/sql/expression.py:1925:
SAWarning: The IN-predicate on "term_translation.term" was invoked with an empty sequence.
This results in a contradiction, which nonetheless can be expensive to evaluate.
Consider alternative strategies for improved performance.
vitorbaptista added a commit that referenced this issue Feb 5, 2013
@vitorbaptista
[#299] Ignore SimpleHTTPServer's log messages
7dbf278
vitorbaptista added a commit that referenced this issue Feb 5, 2013
@vitorbaptista
[#299] Run before_show on ITag before running it on IPackage
4a780f4
vitorbaptista added a commit that referenced this issue Feb 5, 2013
@vitorbaptista
[#299] Fix psql command line in datastore setup
50b5481
vitorbaptista added a commit that referenced this issue Feb 6, 2013
@vitorbaptista
[#299] Clear AuthFunctions cache after loading/unloading plugin
d1f3974
vitorbaptista added a commit that referenced this issue Feb 19, 2013
@vitorbaptista
[#299] Configure DataStore plugin after loading it in tests
9d39b8c 
This is a hack.

We probably should configure all IConfigurable plugins whenever we load a new
one. We have to do this because they're configured before setup_class is ran,
so DataStore never gets configured.
vitorbaptista added a commit that referenced this issue Feb 21, 2013
@vitorbaptista
[#299] Rename clear_cache functions so they're more explicit
c30f00c
vitorbaptista added a commit that referenced this issue Feb 21, 2013
@vitorbaptista
[#299] Refactoring imports to comply to Coding Standards
e8cc863
vitorbaptista added a commit that referenced this issue Feb 21, 2013
@vitorbaptista
[#299] Refactor import ordering
066a06a
@vitorbaptista
Copy link
Contributor Author

This was solved by #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitorbaptista vitorbaptista

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitorbaptista @domoritz