"Add some resources" link shown to unauthorized users #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add auth check to the `new_resource` action on the package controller so the form is not shown to unauthorized users.
|
is this related to #1664 ? |
|
The actual authorization for creating resources is basically the same than for creating/updating the datasets they belong to, so in a way yes. But this is just a matter of showing links and forms on the frontend when you are not authorized, not about how the authorization per se works |
|
Looks good to me. The test failures are unrelated, so I'm merging this in. |
nigelbabu
added a commit
that referenced
this pull request
Jun 17, 2014
"Add some resources" link shown to unauthorized users
amercader
added a commit
that referenced
this pull request
Jul 16, 2014
amercader
added a commit
that referenced
this pull request
Jul 16, 2014
Add auth check to the `new_resource` action on the package controller so the form is not shown to unauthorized users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the stand-alone new resource page (
/dataset/new_resource/dataset_id) shows to unauthorized users