Fix package permission checks for create+update #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same permission checks for both package_update and package_create and check all the applicable config options: anon_create_dataset, create_unowned_dataset and create_dataset_if_not_in_organization
|
@seanh thanks. I'll add some tests. Probably not for all 24 combinations, but a representative sample. |
This allows you to temporarily change a CKAN's config value during a test. It'll restore the values to what they were before, after you test is ran. Conflicts: ckan/new_tests/helpers.py
| @@ -137,3 +139,39 @@ def _get_test_app(): | |||
| app = ckan.config.middleware.make_app(config['global_conf'], **config) | |||
| app = webtest.TestApp(app) | |||
| return app | |||
|
|
|||
|
|
|||
| def change_config(key, value): | |||
wardi
added a commit
that referenced
this pull request
Jun 25, 2014
Use the same permission checks for both package_update and package_create and check all the applicable config options: anon_create_dataset, create_unowned_dataset and create_dataset_if_not_in_organization
wardi
added a commit
that referenced
this pull request
Jun 25, 2014
wardi
added a commit
that referenced
this pull request
Jun 25, 2014
wardi
added a commit
that referenced
this pull request
Jun 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My interpretation of the three configuration options affecting whether a package create+update will be allowed:
This PR implements the checks described in the table above and uses the same code in both create and update operations. The original checks did not cover a number of the combinations possible. One could argue that users shouldn't set permissions certain ways, but I'd rather not have CKAN fail when they do.