email notifications via paster plugin post erroneously demands authentication #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, the |
|
As per @the42's email, this error was on CKAN 2.2a |
The problem is that our validators notice that .send_email_notifications() didn't call its auth functions and raise an Exception. But it shouldn't call it's auth functions when being called with paster anyway, so it's correct. This fixes that.
|
This is ready for review. @the42, if you have some time, could you test if this branch fixes your issue? |
|
Sorry, currently running short on time and helped myself out by calling the API with curl and an API-key in ctrontab. |
Conflicts: ckan/new_tests/logic/action/test_update.py
vitorbaptista
added a commit
that referenced
this pull request
Jul 28, 2014
The problem is that our validators notice that .send_email_notifications() didn't call its auth functions and raise an Exception. But it shouldn't call it's auth functions when being called with paster anyway, so it's correct. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
echo '{}' | /usr/lib/ckan/default/bin/paster --plugin=ckan post -c /etc/ckan/default.ini /api/action/send_email_notifications
the following error is returned:
Error - <type 'exceptions.Exception'>: Action function
send_email_notifications did not call its auth function
<title>Server Error</title>
Server Error
An internal server error occurred
However, when called using curl, auth-key set in header and empty json {}, the action succeeds.