Move PDF views into a separate extension #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it will be moved to a separate extension (https://github.com/ckan/ckanext-pdfview)
This was referenced Feb 6, 2015
Closed
Conflicts: doc/maintaining/data-viewer.rst
| @@ -13,6 +13,10 @@ v2.3 | |||
| API changes and deprecations | |||
| ---------------------------- | |||
|
|
|||
| * The PDF Viewer extension has been moved to a separate extension: | |||
| https://github.com/ckan/ckanext-pdfview. Please install it separately if | |||
| you are using the ``pdf_view`` plugin. | |||
There was a problem hiding this comment.
I guess you should say the plugin is alternatively called "pdf_preview"?
|
Otherwise, this is good to merge |
|
@davidread done |
davidread
pushed a commit
that referenced
this pull request
Feb 17, 2015
Move PDF views into a separate extension
amercader
added a commit
that referenced
this pull request
Feb 17, 2015
As it will be moved to a separate extension (https://github.com/ckan/ckanext-pdfview) Conflicts: doc/maintaining/data-viewer.rst
amercader
added a commit
that referenced
this pull request
Feb 17, 2015
This was referenced Mar 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2231. Will clean up core and make easier to iterate on the pdf viewer.