Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new reCAPTCHA v2.0 #2407

Merged
merged 3 commits into from
Jun 11, 2015
Merged

Support for new reCAPTCHA v2.0 #2407

merged 3 commits into from
Jun 11, 2015

Conversation

AdzRivers
Copy link
Contributor

Support for the new reCAPTCHA on the registration form as seen here: https://www.google.com/recaptcha/intro/index.html.

newrecaptchasupport

Currently CKAN uses reCAPTCHA v1.0, this commit enables support for the
much more user friendly reCAPTCHA v2.0
@amercader amercader self-assigned this Apr 28, 2015
@amercader
Copy link
Member

Many thanks for this @AdzRivers, seems like a useful addition.
AFAICT v2.0 is still a relatively recent technology and some people may want to keep their existing implementation on their sites. Perhaps we could keep support for the previous version adding a ckan.recaptcha.version config option that allows you to choose which version to load, and the code to handle the request differently.

What do you think?

Added config option for reCAPTCHA version which can handle both versions
1 and 2 of reCAPTCHA.
@AdzRivers
Copy link
Contributor Author

@amercader I've added a config option called ckan.recaptcha.version, which changes the version of the recaptcha api used.

@AdzRivers
Copy link
Contributor Author

@TkTech Well spotted, thanks for that! They're now fixed.

@astatke
Copy link

astatke commented May 29, 2015

I was trying to hide the "Privacy and Terms" using this css but to no avail:
.rc-anchor-pt {display: none;}

Could you advise as to how to achieve that?

@mattfullerton
Copy link
Contributor

Try visibility: hidden;
On 30 May 2015 01:06, "astatke" notifications@github.com wrote:

I was trying to hide the "Privacy and Terms" using this css but to no
avail:
.rc-anchor-pt {display: none;}

Could you advise as to how to achieve that?


Reply to this email directly or view it on GitHub
#2407 (comment).

@astatke
Copy link

astatke commented Jun 1, 2015

mattfullerton - thank you for your prompt response.

Unfortunately, it still doesn't work with visibility: hidden;

@mattfullerton
Copy link
Contributor

Do you have an instance of the change running publicly? Depending on what order different CSS files are getting loaded, your change might be getting overridden.

@astatke
Copy link

astatke commented Jun 1, 2015

It is still in development. Below is a screenshot on my followup findings/question:
styling-recaptcha

@mattfullerton
Copy link
Contributor

Why exactly do you want to remove privacy and terms? ;-)

Assuming the method you suggest is possible, maybe you can use a different kind of selector ($("iframe")) with jquery to get a hold of the iframe instead of the id.

@astatke
Copy link

astatke commented Jun 3, 2015

I guess leaving the labels as is should be OK too :)

I will give it a shot and let you know my findings.

~cheers and have a great day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants