Display warning when creating dataset without organizations #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,7 @@ def owner_org_validator(key, data, errors, context): | |||
|
|
|||
| if value is missing or value is None: | |||
| if not authz.check_config_permission('create_unowned_dataset'): | |||
| raise Invalid(_('A organization must be supplied')) | |||
| raise Invalid(_('An organization must be provided')) | |||
There was a problem hiding this comment.
This will break a bunch of existing translations. Just flagging it :)
There was a problem hiding this comment.
That is something that I though about to. But there is no way to avoid it, is there?
k-nut
force-pushed
the
3046-display-warning-when-creating-dataset-without-organizations
branch
from
6a29f20
to
ff93ffb
Compare
|
@amercader The problem with the tests that make each other fail is now fixed. I documented the reasoning for this rather uncommon patching / cache invalidation in the code so that future readers understand what is going on and so that we have a "complex" tests that we could potentially copy from in the future if similar things come up. |
|
I'll make this into a decorator. |
|
Great stuff @k-nut, love |
k-nut
deleted the
3046-display-warning-when-creating-dataset-without-organizations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3046, #2767
Proposed fixes:
As discussed in #3046 already this now checks if there are organizations to which the dataset can be added or not. If there are non it checks if the user is allowed to create on or not and depending on the answer provides them with a link.
The tests are failing right now unfortunately. When either one of them is commented out they both pass but the first one fails when run together. Any idea what this could be? Also I feel bad for having to introduce
patchin those tests again, maybe there is a better way to do it?Features: