Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate image URL in resource form #3668

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

klikstermkd
Copy link
Contributor

Fixes #3660

The image URL field is validated only through the form and not through the API, since as discussed on the meeting call if it's validated on the backend it can cause many issues.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

@klikstermkd
Copy link
Contributor Author

Ready for review.

@amercader amercader merged commit 853f40d into ckan:master Jul 6, 2017
klikstermkd pushed a commit to klikstermkd/ckan that referenced this pull request Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource URL is not validated on create/update
2 participants