Port fixes and features in Bootstrap 2 mode #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
July 23, 2017 12:49
|
Ready for review. |
|
Chromium v59: |
|
@smotornyuk The issues that you pointed are for bs3 mode. This PR ports features and fixes to bs2. Can you create a new issue for the bugs that you found and close this PR? |
|
Sure. With bs2 everything is just works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the migration to Bootstrap 3, two additional folders were created for Bootstrap 2,
public-bs2andtemplates-bs2. Until that PR was merged into master, some features and fixes that were made during that period, were done in the folderspublicandtemplates. So when the PR for Bootstrap 3 was merged, they are now missing frompublic-bs2andtemplates-bs2.This PR ports the following fixes and features that are now in Bootstrap 3 mode, but are missing in Bootstrap 2 mode: #3612, #3617, #3620, #3640, #3657, #3659, #3662, #3664, #3668, #3700, #3710, #3711, #3604, #3531