Fix dataset count display for groups #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dataset counts were not displayed at all for group items because the template checked `packages` rather than `package_count`.
smotornyuk
added
zBackport 2.7.0
zBackport 2.4.8
zBackport 2.5.6
zBackport 2.6.3
and removed
Backport pending
labels
klikstermkd
pushed a commit
to klikstermkd/ckan
that referenced
this pull request
Jul 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataset counts were not displayed at all for group items.
The template never actually rendered 'X Datasets' or '0 Datasets'
because the template checked
packagesrather thanpackage_count.Proposed fixes:
Check
package_countto get the dataset count.Features:
Please [X] all the boxes above that apply