[#4097] Use c.user to test if a user provided in the default auth check #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now we only were checking if context['auth_user_obj'] was set, but that is not always the case, specially when using the auth_disallow_anonymous_access and auth_allow_anonymous_access decorators. This makes the check work as expected.
|
We decided to close old pull requests that are not actively worked on so that we can focus our effort and attention on PRs made against the current version of CKAN. A lot has changed in the last several months and many PRs will have gone stale or may now be in conflict with the latest version. Please note: this isn't a judgement about the quality of your pull request. We just don't have the resources to review older PRs. If you would like to reopen your PR (and update it if necessary), please do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now we only were checking if
context['auth_user_obj']was set, but that is not always the case, specially when using theauth_disallow_anonymous_accessandauth_allow_anonymous_accessdecorators. This makes the check work as expected.Fixes #4097
Fixes #4183