Datastore tests aren't respecting the legacy_mode flag, index creation does not work on PG 8.4 #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
…tic naming is not supported there
|
@vitorbaptista Could you merge this into #562? |
|
@vitorbaptista I'll need to fix the issue with the json type before this can be merged. |
|
@domoritz Ping me whenever you think this patch is OK |
|
I've created a new branch with both your patch and mines, now everything fails, including when testing on 9.1... :/ |
|
@vitorbaptista I guess 690655b was missing because I fixed it a little bit too late. It should work now. |
vitorbaptista
added a commit
that referenced
this pull request
Mar 7, 2013
Datastore tests aren't respecting the legacy_mode flag, index creation does not work on PG 8.4
domoritz
added a commit
that referenced
this pull request
Mar 12, 2013
domoritz
added a commit
that referenced
this pull request
Mar 12, 2013
domoritz
added a commit
that referenced
this pull request
Mar 12, 2013
domoritz
added a commit
that referenced
this pull request
Mar 12, 2013
domoritz
added a commit
that referenced
this pull request
Mar 12, 2013
…tic naming is not supported there
domoritz
added a commit
that referenced
this pull request
Mar 12, 2013
domoritz
added a commit
that referenced
this pull request
Mar 12, 2013
domoritz
added a commit
that referenced
this pull request
Mar 12, 2013
domoritz
added a commit
that referenced
this pull request
Mar 12, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes the tests, refactors them a little bit and fixes the index error on pg 8.4.