Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5667] Add secondary order_by to sorting by number_created_packages #5668

Merged
merged 2 commits into from
Oct 22, 2020
Merged

[#5667] Add secondary order_by to sorting by number_created_packages #5668

merged 2 commits into from
Oct 22, 2020

Conversation

Zharktas
Copy link
Member

Fixes #5667

Proposed fixes:

Adds secondary sorting to order_by when sorting by number of created packages. This should fix flaky test as order_by is not guaranteed to be stable.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@amercader amercader added the WIP label Oct 15, 2020
@Zharktas Zharktas removed the WIP label Oct 22, 2020
@wardi wardi merged commit 4c1c707 into ckan:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
zBackport 2.7.10 zBackport 2.8.7 zBackport 2.9.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User list sorting by number_created_packages is not stable
3 participants
@Zharktas @wardi @amercader