Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean ckan.validated_data_dict config #6628

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Jan 5, 2022

Currently CKAN has a strong dependency on validated_data_dict so config.get_value('ckan.cache_validated_datasets') option is now mandatory and cannot be set to False.

To review just set the config to False and running our test suit. It will throw hundreds of errors.

I'm removing the config to avoid confusion.

The failing test seems to be a random fail, but let me know if the opposite.

(.venv)  ~/Repos/ckan (clean-cache-validated-datasets-config)$ pytest --ckan-ini=test-core.ini --disable-warnings ckanext/datapusher/tests/
2022-01-10 19:34:22,481 CRITI [ckan.lib.uploader] Please specify a ckan.storage_path in your config
                         for your uploads
=========================================================================================== test session starts ===========================================================================================
platform linux -- Python 3.8.10, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /home/pdelboca/Repos/ckan, configfile: pyproject.toml
plugins: rerunfailures-9.1.1, cov-2.11.1, factoryboy-2.1.0, split-tests-1.0.9, Faker-9.3.1, freezegun-0.4.2, pyfakefs-3.2
collected 14 items                                                                                                                                                                                        

ckanext/datapusher/tests/test_action.py .........                                                                                                                                                   [ 64%]
ckanext/datapusher/tests/test_default_views.py ..                                                                                                                                                   [ 78%]
ckanext/datapusher/tests/test_interfaces.py ..                                                                                                                                                      [ 92%]
ckanext/datapusher/tests/test_views.py .                                                                                                                                                            [100%]

=========================================================================================== 14 passed in 26.75s ===========================================================================================

@amercader amercader self-assigned this Jan 11, 2022
@amercader amercader merged commit 2bcf68b into ckan:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants