#726 Fix page zoom out render issue #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @johnmartin, how may I test it? Is it simply opening CKAN main page and trying zooming in/out in a few different browsers? |
ghost
assigned 
|
@vitorbaptista It only effects pages with 2 columns. |
|
@johnmartin Is it what this pr should fix? If so, I still could reproduce it using your patch in Chrome 23.0.1271.91 in Linux. |
|
@vitorbaptista Which zoom level is that? and have you run |
vitorbaptista
added a commit
that referenced
this pull request
Apr 11, 2013
#726 Fix page zoom out render issue
|
Duh... you're right. I forgot to recompile the CSS. Just merged this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #726
Requires: a
./bin/less --productionafter mergeNote: This fix works up to 4 levels of zoom out. Once you get past
zoom: 0.6this still happens. However in order to fix this in cases where the user zooms out < 0.6 it'd involve some very horrible JS [1] to detect a difference in zoom level and then adjust some item widths accordingly. I don't really want to add JS module for such a minor edge case.[1] http://stackoverflow.com/questions/1713771/how-to-detect-page-zoom-level-in-all-modern-browsers/5078596#5078596