Datatables View Ext: Null / NoneType Front-End Label Option & Helper #7574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new config option `ckan.null_label`. - Added new helper `get_null_label`. - Used `get_null_label` in datatables view.
- Added change log file.
- Set return of `get_null_label` helper to blank string.
wardi
reviewed
May 3, 2023
wardi
reviewed
May 3, 2023
wardi
reviewed
May 3, 2023
wardi
reviewed
May 3, 2023
- Moved all code from core to datatablesview plugin.
|
@wardi okay the code has been moved to the datatablesview extension exclusively. The config option name has been updated, and the declaration moved. The helper has also been moved into datatablesview ext. The config option has been simplified, so it will just be a string and the helper will now just return the value of the option, put through gettext. If the option is not set, the helper will just return a blank string. |
- Slightly improved return on the `get_helpers` implementation;moved condition into single lambda function.
- Fixed continual line over-indent.
JVickery-TBS
changed the title
wardi
reviewed
May 3, 2023
wardi
reviewed
May 3, 2023
wardi
reviewed
May 3, 2023
- Updated config option name in change log. - Updated helper name. - Moved helper function from lambda to helpers module. - Added to change log.
- Fixed flake8 reportings.
wardi
reviewed
May 4, 2023
- Added empty string as default value to `ckan.datatables.null_label` declaration.
smotornyuk
reviewed
May 11, 2023
- Added encoding to helpers script. - Used `toolkit.blanket.helpers` instead of `plugin.implements`.
- Removed unused imports.
wardi
added a commit
to open-data/ckan
that referenced
this pull request
Jun 22, 2023
JVickery-TBS
pushed a commit
to open-data/ckan
that referenced
this pull request
Jun 27, 2023
Datatables View Ext: Null / NoneType Front-End Label Option & Helper # Conflicts: # ckanext/datatablesview/blueprint.py # ckanext/datatablesview/config_declaration.yaml # ckanext/datatablesview/plugin.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(frontend): added null label;
ckan.null_label.get_null_label.get_null_labelin datatables view.Fixes #
Added a new config option and helper to set labels for NoneType (or null from sql) string labels. This is to be used to display NoneType values on the front-end.
The new config option also supports a dict for i18n labels.
Included is its use in the datatableview plugin to display null datastore values with the label instead of it casting NoneType to the string of
"None".Features:
Please [X] all the boxes above that apply