Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatables View Ext: Null / NoneType Front-End Label Option & Helper #7574

Merged
merged 11 commits into from May 21, 2023
Merged

Datatables View Ext: Null / NoneType Front-End Label Option & Helper #7574

merged 11 commits into from May 21, 2023

Commits on May 2, 2023

  1. feat(frontend): added null label; 

    - Added new config option `ckan.null_label`.
- Added new helper `get_null_label`.
- Used `get_null_label` in datatables view.
    @JVickery-TBS
    JVickery-TBS committed May 2, 2023
    Configuration menu
    Copy the full SHA
    33a6eff View commit details
    Browse the repository at this point in the history

  2. feat(frontend): added change log; 

    - Added change log file.
    @JVickery-TBS
    JVickery-TBS committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c1c1561 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. feat(frontend): changed null label default return; 

    - Set return of `get_null_label` helper to blank string.
    @JVickery-TBS
    JVickery-TBS committed May 3, 2023
    Configuration menu
    Copy the full SHA
    470cbf8 View commit details
    Browse the repository at this point in the history

  2. feat(frontend): moved null label to datatableviews plugin; 

    - Moved all code from core to datatablesview plugin.
    @JVickery-TBS
    JVickery-TBS committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5315108 View commit details
    Browse the repository at this point in the history

  3. feat(frontend): better null label helper; 

    - Slightly improved return on the `get_helpers` implementation;moved condition into single lambda function.
    @JVickery-TBS
    JVickery-TBS committed May 3, 2023
    Configuration menu
    Copy the full SHA
    260dfaf View commit details
    Browse the repository at this point in the history

  4. fix(syntax): flake8 syntax fix; 

    - Fixed continual line over-indent.
    @JVickery-TBS
    JVickery-TBS committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2fca690 View commit details
    Browse the repository at this point in the history

  5. feat(frontend): updated helper name; 

    - Updated config option name in change log.
- Updated helper name.
- Moved helper function from lambda to helpers module.
- Added to change log.
    @JVickery-TBS
    JVickery-TBS committed May 3, 2023
    Configuration menu
    Copy the full SHA
    20fb5b3 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. fix(frontend): helper module syntax fix; 

    - Fixed flake8 reportings.
    @JVickery-TBS
    JVickery-TBS committed May 4, 2023
    Configuration menu
    Copy the full SHA
    322376e View commit details
    Browse the repository at this point in the history

  2. feat(frontend): added default value to declaration; 

    - Added empty string as default value to `ckan.datatables.null_label` declaration.
    @JVickery-TBS
    JVickery-TBS committed May 4, 2023
    Configuration menu
    Copy the full SHA
    ecce6bb View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. fix(helpers): adding encoding, used blankets; 

    - Added encoding to helpers script.
- Used `toolkit.blanket.helpers` instead of `plugin.implements`.
    @JVickery-TBS
    JVickery-TBS committed May 19, 2023
    Configuration menu
    Copy the full SHA
    86d3b4a View commit details
    Browse the repository at this point in the history

  2. fix(syntax): fixed flake and pyright issues; 

    - Removed unused imports.
    @JVickery-TBS
    JVickery-TBS committed May 19, 2023
    Configuration menu
    Copy the full SHA
    9d7c2b8 View commit details
    Browse the repository at this point in the history