-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recurring travis fail no such option 'with-pylons'
#766
Recurring travis fail no such option 'with-pylons'
#766
Conversation
This is due to pip-install failing like so
We could catch this error and try again. In most instances this would fix the problem. It might be worth sleeping a short while and limiting the number of retries. This is hard to test :( but seems like it would fix the problem. |
I wonder if it would help to add a second pip install line. If everything worked fine, that should be fine to do and would give a second chance in case something didn't work fine. |
I've asked in #travis, and opened an issue to try to find the best option to solve this in travis-ci/travis-ci#1521. |
To do so, I needed to split our ./bin/travis-build in two files, one with the deps install, and one with the test run. Doing so allows me to use the "install" directive in Travis, and break the build as soon as something fails with it.
I was unable to run Jetty-Solr's configuration on travis-install-dependencies. Probably something to do with Bash's "set -e", but I was unable to pinpoint exactly, so I left it into travis-run-tests. No big deal.
Conflicts: bin/travis-install-dependencies
I've split up Travis' installing dependencies and running tests into two files. With these patches, Travis will fail as soon as we get some error installing deps, and won't try to run the tests. This solves this issue. |
@domoritz @nigelbabu Whenever you have some time, please review/merge this. |
I might be wrong but I think there is an option to tell shell scripts to return if one line returns an exit code other than 0. |
Yep, that's what the |
Cool, I tried to google it but couldn't find anything. Looks good to me. |
Yeah, I didn't even know that it existed, until @henrikhodne told me in travis-ci/travis-ci#1521. May you merge it, then? :-) |
@domoritz ping |
…tall-fails Recurring travis fail `no such option 'with-pylons'`
👍 |
For example in https://travis-ci.org/okfn/ckan/jobs/6243730